Skip to content

Commit

Permalink
powerpc/mpc5xxx: Add missing fwnode_handle_put()
Browse files Browse the repository at this point in the history
[ Upstream commit b9bbbf4 ]

In mpc5xxx_fwnode_get_bus_frequency(), we should add
fwnode_handle_put() when break out of the iteration
fwnode_for_each_parent_node() as it will automatically
increase and decrease the refcounter.

Fixes: de06fba ("powerpc/mpc5xxx: Switch mpc5xxx_get_bus_frequency() to use fwnode")
Signed-off-by: Liang He <windhl@126.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230322030423.1855440-1-windhl@126.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
windhl authored and gregkh committed Sep 13, 2023
1 parent 4515f16 commit e83f5e2
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion arch/powerpc/sysdev/mpc5xxx_clocks.c
Expand Up @@ -25,8 +25,10 @@ unsigned long mpc5xxx_fwnode_get_bus_frequency(struct fwnode_handle *fwnode)

fwnode_for_each_parent_node(fwnode, parent) {
ret = fwnode_property_read_u32(parent, "bus-frequency", &bus_freq);
if (!ret)
if (!ret) {
fwnode_handle_put(parent);
return bus_freq;
}
}

return 0;
Expand Down

0 comments on commit e83f5e2

Please sign in to comment.