Skip to content

Commit

Permalink
genirq/timings: Fix error return code in irq_timings_test_irqs()
Browse files Browse the repository at this point in the history
[ Upstream commit 290fdc4 ]

Return a negative error code from the error handling case instead of 0, as
done elsewhere in this function.

Fixes: f52da98 ("genirq/timings: Add selftest for irqs circular buffer")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Zhen Lei authored and gregkh committed Sep 15, 2021
1 parent 10d3bdd commit e9a902f
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions kernel/irq/timings.c
Expand Up @@ -799,12 +799,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti)

__irq_timings_store(irq, irqs, ti->intervals[i]);
if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
ret = -EBADSLT;
pr_err("Failed to store in the circular buffer\n");
goto out;
}
}

if (irqs->count != ti->count) {
ret = -ERANGE;
pr_err("Count differs\n");
goto out;
}
Expand Down

0 comments on commit e9a902f

Please sign in to comment.