Skip to content

Commit

Permalink
ASoC: mediatek: Fix error handling in mt8173_max98090_dev_probe
Browse files Browse the repository at this point in the history
[ Upstream commit 4f4e045 ]

Call of_node_put(platform_node) to avoid refcount leak in
the error path.

Fixes: 94319ba ("ASoC: mediatek: Use platform_of_node for machine drivers")
Fixes: 4934337 ("ASoC: mediatek: mt8173: fix device_node leak")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://lore.kernel.org/r/20220404092903.26725-1-linmq006@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Yuuoniy authored and gregkh committed Jun 9, 2022
1 parent dbc3526 commit ebd5cb4
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion sound/soc/mediatek/mt8173/mt8173-max98090.c
Expand Up @@ -167,7 +167,8 @@ static int mt8173_max98090_dev_probe(struct platform_device *pdev)
if (!codec_node) {
dev_err(&pdev->dev,
"Property 'audio-codec' missing or invalid\n");
return -EINVAL;
ret = -EINVAL;
goto put_platform_node;
}
for_each_card_prelinks(card, i, dai_link) {
if (dai_link->codecs->name)
Expand All @@ -179,6 +180,8 @@ static int mt8173_max98090_dev_probe(struct platform_device *pdev)
ret = devm_snd_soc_register_card(&pdev->dev, card);

of_node_put(codec_node);

put_platform_node:
of_node_put(platform_node);
return ret;
}
Expand Down

0 comments on commit ebd5cb4

Please sign in to comment.