Skip to content

Commit

Permalink
i2c: hix5hd2: fix IRQ check
Browse files Browse the repository at this point in the history
[ Upstream commit f9b459c ]

Iff platform_get_irq() returns 0, the driver's probe() method will return 0
early (as if the method's call was successful).  Let's consider IRQ0 valid
for simplicity -- devm_request_irq() can always override that decision...

Fixes: 15ef277 ("i2c: hix5hd2: add i2c controller driver")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Sergey Shtylyov authored and gregkh committed Sep 15, 2021
1 parent d36ab9b commit ee029e3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/i2c/busses/i2c-hix5hd2.c
Expand Up @@ -413,7 +413,7 @@ static int hix5hd2_i2c_probe(struct platform_device *pdev)
return PTR_ERR(priv->regs);

irq = platform_get_irq(pdev, 0);
if (irq <= 0)
if (irq < 0)
return irq;

priv->clk = devm_clk_get(&pdev->dev, NULL);
Expand Down

0 comments on commit ee029e3

Please sign in to comment.