Skip to content

Commit

Permalink
crypto: stm32/cryp - Fix PM reference leak on stm32-cryp.c
Browse files Browse the repository at this point in the history
[ Upstream commit 747bf30 ]

pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Signed-off-by: Shixin Liu <liushixin2@huawei.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
Shixin Liu authored and gregkh committed May 12, 2021
1 parent 994169b commit ef8b29f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/crypto/stm32/stm32-cryp.c
Expand Up @@ -542,7 +542,7 @@ static int stm32_cryp_hw_init(struct stm32_cryp *cryp)
int ret;
u32 cfg, hw_mode;

pm_runtime_get_sync(cryp->dev);
pm_runtime_resume_and_get(cryp->dev);

/* Disable interrupt */
stm32_cryp_write(cryp, CRYP_IMSCR, 0);
Expand Down Expand Up @@ -2043,7 +2043,7 @@ static int stm32_cryp_remove(struct platform_device *pdev)
if (!cryp)
return -ENODEV;

ret = pm_runtime_get_sync(cryp->dev);
ret = pm_runtime_resume_and_get(cryp->dev);
if (ret < 0)
return ret;

Expand Down

0 comments on commit ef8b29f

Please sign in to comment.