Skip to content

Commit

Permalink
ARM: dts: exynos: correct PMIC interrupt trigger level on Odroid XU3 …
Browse files Browse the repository at this point in the history
…family

[ Upstream commit 3e7d9a5 ]

The Samsung PMIC datasheets describe the interrupt line as active low
with a requirement of acknowledge from the CPU.  The falling edge
interrupt will mostly work but it's not correct.

Fixes: aac4e06 ("ARM: dts: odroidxu3: Enable wake alarm of S2MPS11 RTC")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20201210212903.216728-6-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
krzk authored and gregkh committed Mar 4, 2021
1 parent d32a943 commit f0f9e91
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/exynos5422-odroid-core.dtsi
Expand Up @@ -141,7 +141,7 @@
samsung,s2mps11-acokb-ground;

interrupt-parent = <&gpx0>;
interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
interrupts = <4 IRQ_TYPE_LEVEL_LOW>;
pinctrl-names = "default";
pinctrl-0 = <&s2mps11_irq>;

Expand Down

0 comments on commit f0f9e91

Please sign in to comment.