Skip to content

Commit

Permalink
ALSA: hda/tas2781: do not reset cur_* values in runtime_suspend
Browse files Browse the repository at this point in the history
[ Upstream commit bec7760a6c5fa59593dac264fa0c628e46815986 ]

The amplifier doesn't loose register state in software shutdown mode, so
there is no need to reset the cur_* values.

Without these resets, the amplifier can be turned on after
runtime_suspend without waiting for the program and
profile to be restored.

Fixes: 5be27f1 ("ALSA: hda/tas2781: Add tas2781 HDA driver")
Signed-off-by: Gergo Koteles <soyer@irl.hu>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Message-ID: <aa27ae084150988bf6a0ead7e3403bc485d790f8.1709918447.git.soyer@irl.hu>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
soyersoyer authored and Sasha Levin committed Mar 26, 2024
1 parent 9b8d6c4 commit f60e955
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions sound/pci/hda/tas2781_hda_i2c.c
Expand Up @@ -740,7 +740,6 @@ static void tas2781_hda_i2c_remove(struct i2c_client *clt)
static int tas2781_runtime_suspend(struct device *dev)
{
struct tas2781_hda *tas_hda = dev_get_drvdata(dev);
int i;

dev_dbg(tas_hda->dev, "Runtime Suspend\n");

Expand All @@ -751,12 +750,6 @@ static int tas2781_runtime_suspend(struct device *dev)
tas_hda->priv->playback_started = false;
}

for (i = 0; i < tas_hda->priv->ndev; i++) {
tas_hda->priv->tasdevice[i].cur_book = -1;
tas_hda->priv->tasdevice[i].cur_prog = -1;
tas_hda->priv->tasdevice[i].cur_conf = -1;
}

mutex_unlock(&tas_hda->priv->codec_lock);

return 0;
Expand Down

0 comments on commit f60e955

Please sign in to comment.