Skip to content

Commit

Permalink
drm/mcde: Fix handling of platform_get_irq() error
Browse files Browse the repository at this point in the history
[ Upstream commit e2dae67 ]

platform_get_irq() returns -ERRNO on error.  In such case comparison
to 0 would pass the check.

Fixes: 5fc537b ("drm/mcde: Add new driver for ST-Ericsson MCDE")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20200827071107.27429-1-krzk@kernel.org
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
krzk authored and gregkh committed Dec 30, 2020
1 parent 29f34fe commit f61e9db
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/gpu/drm/mcde/mcde_drv.c
Expand Up @@ -410,8 +410,8 @@ static int mcde_probe(struct platform_device *pdev)
}

irq = platform_get_irq(pdev, 0);
if (!irq) {
ret = -EINVAL;
if (irq < 0) {
ret = irq;
goto clk_disable;
}

Expand Down

0 comments on commit f61e9db

Please sign in to comment.