Skip to content

Commit

Permalink
task_stack: Fix end_of_stack() for architectures with upwards-growing…
Browse files Browse the repository at this point in the history
… stack

[ Upstream commit 9cc2fa4 ]

The function end_of_stack() returns a pointer to the last entry of a
stack. For architectures like parisc where the stack grows upwards
return the pointer to the highest address in the stack.

Without this change I faced a crash on parisc, because the stackleak
functionality wrote STACKLEAK_POISON to the lowest address and thus
overwrote the first 4 bytes of the task_struct which included the
TIF_FLAGS.

Signed-off-by: Helge Deller <deller@gmx.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
hdeller authored and gregkh committed Nov 18, 2021
1 parent 3b935cc commit f6ca0ac
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions include/linux/sched/task_stack.h
Expand Up @@ -25,7 +25,11 @@ static inline void *task_stack_page(const struct task_struct *task)

static inline unsigned long *end_of_stack(const struct task_struct *task)
{
#ifdef CONFIG_STACK_GROWSUP
return (unsigned long *)((unsigned long)task->stack + THREAD_SIZE) - 1;
#else
return task->stack;
#endif
}

#elif !defined(__HAVE_THREAD_FUNCTIONS)
Expand Down

0 comments on commit f6ca0ac

Please sign in to comment.