Skip to content

Commit

Permalink
usbip: Fix incorrect double assignment to udc->ud.tcp_rx
Browse files Browse the repository at this point in the history
commit 9858af2 upstream.

Currently udc->ud.tcp_rx is being assigned twice, the second assignment
is incorrect, it should be to udc->ud.tcp_tx instead of rx. Fix this.

Fixes: 46613c9 ("usbip: fix vudc usbip_sockfd_store races leading to gpf")
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Cc: stable <stable@vger.kernel.org>
Addresses-Coverity: ("Unused value")
Link: https://lore.kernel.org/r/20210311104445.7811-1-colin.king@canonical.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Colin Ian King authored and gregkh committed Mar 24, 2021
1 parent 251949e commit f893661
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/usbip/vudc_sysfs.c
Expand Up @@ -174,7 +174,7 @@ static ssize_t usbip_sockfd_store(struct device *dev,

udc->ud.tcp_socket = socket;
udc->ud.tcp_rx = tcp_rx;
udc->ud.tcp_rx = tcp_tx;
udc->ud.tcp_tx = tcp_tx;
udc->ud.status = SDEV_ST_USED;

spin_unlock_irq(&udc->ud.lock);
Expand Down

0 comments on commit f893661

Please sign in to comment.