Skip to content

Commit

Permalink
media: meson: vdec: fix possible refcount leak in vdec_probe()
Browse files Browse the repository at this point in the history
[ Upstream commit 7718999 ]

v4l2_device_unregister need to be called to put the refcount got by
v4l2_device_register when vdec_probe fails or vdec_remove is called.

Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
HBh25Y authored and gregkh committed Nov 10, 2022
1 parent 8b785cd commit f96ad39
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/staging/media/meson/vdec/vdec.c
Original file line number Diff line number Diff line change
Expand Up @@ -1105,6 +1105,7 @@ static int vdec_probe(struct platform_device *pdev)

err_vdev_release:
video_device_release(vdev);
v4l2_device_unregister(&core->v4l2_dev);
return ret;
}

Expand All @@ -1113,6 +1114,7 @@ static int vdec_remove(struct platform_device *pdev)
struct amvdec_core *core = platform_get_drvdata(pdev);

video_unregister_device(core->vdev_dec);
v4l2_device_unregister(&core->v4l2_dev);

return 0;
}
Expand Down

0 comments on commit f96ad39

Please sign in to comment.