Skip to content

Commit

Permalink
netrom: Fix a data-race around sysctl_netrom_transport_maximum_tries
Browse files Browse the repository at this point in the history
[ Upstream commit e799299 ]

We need to protect the reader reading the sysctl value because the
value can be changed concurrently.

Fixes: 1da177e ("Linux-2.6.12-rc2")
Signed-off-by: Jason Xing <kernelxing@tencent.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
JasonXing authored and Sasha Levin committed Mar 15, 2024
1 parent 5d5c14e commit fa3f3ab
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/netrom/af_netrom.c
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ static int nr_create(struct net *net, struct socket *sock, int protocol,
nr->t2 =
msecs_to_jiffies(sysctl_netrom_transport_acknowledge_delay);
nr->n2 =
msecs_to_jiffies(sysctl_netrom_transport_maximum_tries);
msecs_to_jiffies(READ_ONCE(sysctl_netrom_transport_maximum_tries));
nr->t4 =
msecs_to_jiffies(sysctl_netrom_transport_busy_delay);
nr->idle =
Expand Down

0 comments on commit fa3f3ab

Please sign in to comment.