Skip to content

Commit

Permalink
ALSA: hda: Add IRQ check for platform_get_irq()
Browse files Browse the repository at this point in the history
[ Upstream commit 8c13212 ]

The function hda_tegra_first_init() neglects to check the return
value after executing platform_get_irq().

hda_tegra_first_init() should check the return value (if negative
error number) for errors so as to not pass a negative value to
the devm_request_irq().

Fix it by adding a check for the return value irq_id.

Signed-off-by: Jiajun Cao <jjcao20@fudan.edu.cn>
Signed-off-by: Xin Tan <tanxin.ctf@gmail.com>
Reviewed-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20210622131947.94346-1-jjcao20@fudan.edu.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
caojiajunss authored and gregkh committed Jul 20, 2021
1 parent 63c49cf commit fb7c8bf
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions sound/pci/hda/hda_tegra.c
Expand Up @@ -302,6 +302,9 @@ static int hda_tegra_first_init(struct azx *chip, struct platform_device *pdev)
const char *sname, *drv_name = "tegra-hda";
struct device_node *np = pdev->dev.of_node;

if (irq_id < 0)
return irq_id;

err = hda_tegra_init_chip(chip, pdev);
if (err)
return err;
Expand Down

0 comments on commit fb7c8bf

Please sign in to comment.