Skip to content

Commit

Permalink
Issue: 1936 fix Missing MEmberRoleId for group link creation
Browse files Browse the repository at this point in the history
  • Loading branch information
Daniel Richardson committed May 9, 2024
1 parent aee1e19 commit 3291483
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions groups.go
Original file line number Diff line number Diff line change
Expand Up @@ -881,6 +881,7 @@ func (s *GroupsService) GetGroupSAMLLink(gid interface{}, samlGroupName string,
type AddGroupSAMLLinkOptions struct {
SAMLGroupName *string `url:"saml_group_name,omitempty" json:"saml_group_name,omitempty"`
AccessLevel *AccessLevelValue `url:"access_level,omitempty" json:"access_level,omitempty"`
MemberRoleID *int `url:"member_role_id,omitempty" json:"member_role_id,omitempty"`
}

// AddGroupSAMLLink creates a new group SAML link. Available only for users who
Expand Down
1 change: 1 addition & 0 deletions groups_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -569,6 +569,7 @@ func TestAddGroupSAMLLinkCustomRole(t *testing.T) {
opt := &AddGroupSAMLLinkOptions{
SAMLGroupName: Ptr("gitlab_group_example_developer"),
AccessLevel: Ptr(DeveloperPermissions),
MemberRoleID: Ptr(123),
}

link, _, err := client.Groups.AddGroupSAMLLink(1, opt)
Expand Down

0 comments on commit 3291483

Please sign in to comment.