Introduce new EventLabel type for webhook events #1595
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I implemented option 2 from #1594, which replaces all
Label
webhook event fields with a newEventLabel
type that contains the correct fields.How it was tested
I updated the unmarshal tests for all event types that contain labels, without touching the testdata. (These tests were not previously inspecting labels.)
Notes
EventLabel
.EventLabel
struct, I considered makingProjectID
andGroupID
of type*int
because they are technically nullable. GitLab will populate whichever field matches the labelType
. However, since this struct is never marshalled, I decided to keep them asint
.Closes #1594