Add approval_rules in protected_environments #1727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
requested changes
May 31, 2023
protected_environments_test.go
Outdated
| "required_approvals": 2, | ||
| "group_inheritance_type": 1 | ||
| } | ||
| ] |
There was a problem hiding this comment.
I looks like your indention is incorrect here...
There was a problem hiding this comment.
Well spotted, probably the paste from the official doc that went wrong.
|
@svanharmelen thanks for the quick review; I addressed the comments, let me know if you spot anything else! |
svanharmelen
approved these changes
May 31, 2023
Aaaah yes that was it, thanks for spotting it, I'll need to adjust my editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from here: https://gitlab.com/gitlab-org/terraform-provider-gitlab/-/issues/1417