-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new runner api support #1769
Add new runner api support #1769
Conversation
@svanharmelen - This should be ready for review when you have a moment! |
Thank you @PatrickRice-KSC ! I just found your PR, because I am also looking forward to this feature in the terraform provider. To my knowledge working on the tf provider resource should already work with Edit: OK, I understand now. Because of the changes that might still be needed. Nvm, ignore me. |
You're right, I could actually compile the library, use it locally, the develop that way. Sander is usually pretty quick on the review though, and between that an Renovate it means it's usually just cleaner to write it cleanly the first time :) . No worries on the pressure on the provider, I know it's a highly anticipated resource! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @PatrickRice-KSC 👋🏻 Take a look to the things I changed in the last commit and please try to follow the same style and pattern next time 😉
Thanks!
Will do; thanks @svanharmelen ! |
This MR adds support for the new user-based Gitlab Runner API, documented here: https://docs.gitlab.com/ee/api/users.html#create-a-runner
It's worth noting that it's in the
users.go
file even though it's creating a runner, because it's in the/user
api space. I could be convinced to move it to therunners.go
file pretty easily, but figured the default stance was to align to the upstream API space.It's also worth noting that there is no
/users/runner
DELETE api, because it uses the existing APIs withinrunners.go
to delete by ID.Let me know if you have any questions! I'd appreciate cutting a new version after merging this MR so that I can start working on the tf provider resource :)