Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ExtendedTrailers to snippets struct #1957

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Conversation

yecaowulei
Copy link
Contributor

The version of gitlab I am using is v17.0.1, and while modifying the gitlab file using the go-gitlab library, I encountered an error "json: cannot unmarshal array into Go value of type gitlab.Commit",Screening is found that the new gitlab interface/projects / : id/repository/commits Extended_trailers increases the field, so you need to in commits. Go in the structure of the Commit increase to solve this problem. See https://docs.gitlab.com/ee/api/commits.html gitlab document

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure you use Go style field names (check the rest of the package as well and please follow the used and expected naming conventions). This would mean calling the field ExtendedTrailers instead ofExtended_trailers.

And also make sure to format your code (using gofumpt). Thanks!

@yecaowulei
Copy link
Contributor Author

Please make sure you use Go style field names (check the rest of the package as well and please follow the used and expected naming conventions). This would mean calling the field ExtendedTrailers instead ofExtended_trailers.

And also make sure to format your code (using gofumpt). Thanks!

I'm sorry, I didn't notice this naming problem, it's been fixed

@svanharmelen
Copy link
Member

I see that you fixed the naming, thanks! But it still needs to be formatted as well before I can merge it...

@yecaowulei yecaowulei changed the title Add Extended_trailers to snippets struct Add ExtendedTrailers to snippets struct Jun 18, 2024
@yecaowulei
Copy link
Contributor Author

yecaowulei commented Jun 18, 2024

I see that you fixed the naming, thanks! But it still needs to be formatted as well before I can merge it...

It has been handled, please help to check whether it is OK. Thank you very much

Copy link
Member

@svanharmelen svanharmelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @yecaowulei 👍🏻

@svanharmelen svanharmelen merged commit a62c545 into xanzy:main Jun 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants