CA-221864: Fix bugs in vhd_journal_read_locators() #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewed-by: Stefano Panella |
- Return value from vhd_journal_position() not checked; ensure it is valid before continuing - In case of error inside the for loop, always free 'buf'; if 'NULL', memory has not been allocated (1st iter) or the pointer is already added to '_locators' (all other iters); if not 'NULL', pointer not copied to '_locators' yet Signed-off-by: Kostas Ladopoulos <konstantinos.ladopoulos@citrix.com> Reviewed-by: Stefano Panella <stefano.panella@citrix.com>
kostaslambda
force-pushed
the
CA-221864
branch
from
1679ac7
to
9a79562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure it is valid before continuing
if 'NULL', memory has not been allocated (1st iter) or the
pointer is already added to '_locators' (all other iters);
if not 'NULL', pointer not copied to '_locators' yet
Signed-off-by: Kostas Ladopoulos konstantinos.ladopoulos@citrix.com