CA-223652: Add delay to reduce number of syslog messages #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The formatting of this function is a bit all over the place, could reformat the function as part of this change, maybe as a different commit in the set? |
| @@ -926,6 +926,7 @@ static int | |||
| tapdisk_control_pause_vbd(struct tapdisk_ctl_conn *conn, | |||
| tapdisk_message_t *request, tapdisk_message_t * const response) | |||
| { | |||
| struct timeval now, next = { 0, 0 }, interval = { 0, 10000 }; | |||
There was a problem hiding this comment.
Should we do this 100ms ?
There was a problem hiding this comment.
it currently seems happy at 10ms but it's easy enough to change
There was a problem hiding this comment.
ok, looks good to me than
|
Sorry, can you please just split the commit message and the explanation? |
MarkSymsCtx
force-pushed
the
CA-223652
branch
from
f731044
to
e7c612b
Compare
MarkSymsCtx
changed the title
stefanopanella
approved these changes
Sep 28, 2016
|
Reviewed-by: Stefano Panella |
MarkSymsCtx
force-pushed
the
CA-223652
branch
from
e7c612b
to
3cbf316
Compare
Add delay in between attempts to pause the same vbd so that the syslog doesn't get hard spammed for no benefit Signed-off-by: Mark Syms <mark.syms@citrix.com> Reviewed-by: Stefano Panella <stefano.panella@citrix.com>
MarkSymsCtx
force-pushed
the
CA-223652
branch
from
3cbf316
to
82bcec9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add delay in between attempts to pause the same vbd so that the syslog doesn't get hard spammed for no benefit
Signed-off-by: Mark Syms mark.syms@citrix.com