Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-20761: Get suitable ppx changes into trunk #24

Closed
wants to merge 4 commits into from
Closed

Conversation

gaborigloi
Copy link
Contributor

Get the ppx changes from the ppx-ely branch that are compatible with it into master:

  • rename the conflicting Result module,
  • rename the conflicting Switch module,
  • remove the use of camlp4 lwt syntax

The corresponding ppx_trunk branch based on this one can be found here: https://github.com/xapi-project/message-switch/tree/ppx_trunk

This PR makes the difference between the master and ppx branches smaller, to make the future merging easier.

jonludlam and others added 4 commits February 23, 2017 14:41
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
Rename switch.ml to mswitch.ml to prevent the name clash that occurs
with the newer 4.02.3 OCaml compiler.

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
We are moving away from camlp4 to ppx.

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
from the message_switch_server, message_switch_async, message_switch_lwt
libraries that don't use it.

Signed-off-by: Gabor Igloi <gabor.igloi@citrix.com>
Copy link
Contributor

@lindig lindig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. It involves manually re-writing Lwt syntax to a monadic style. I believe the conversion is faithful. It would be good to have second pair of eyes look at this.

@gaborigloi gaborigloi closed this Feb 23, 2017
@gaborigloi gaborigloi deleted the master_ppx branch February 23, 2017 17:15
lindig pushed a commit to lindig/message-switch that referenced this pull request Oct 5, 2018
Change license from LGPL to ISC
edwintorok pushed a commit to edwintorok/message-switch that referenced this pull request Sep 20, 2021
opam: update opam file and fix uninstall section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants