CA-289145: close socket if error occurs when using lwt connect

[krizex]

Signed-off-by: Yang Qian yang.qian@citrix.com

[mseri]

If the fd has been closed at line 43 this will fail with Unix.EBADF and shadow the real exception below. You should probably put it in a Lwt.catch ignoring any error in this line

[mseri]

Also don't use the semicolon but bind it to the Lwt.fail below

[krizex]

Updated.

[mseri]

>>= should be >>= fun () ->

[mseri]

Worth mentioning that (fun () -> Lwt_unix.close fd) is the default value for ?close, but I'd keep it there for clarity

[krizex]

The purpose of the code is quite clear. I think we don't need to add any more comment for it.
If David omitted the ~close parameter when constructing ic, then I think he should add note here that says "the default value of ?close is to close the fd"

[mseri]

I think it's fine anyways

[mseri]

As with some other PRs, please fix the typo and once the Travis build passes feel free to merge

[mseri]

Travis is failing with

# File "lwt/protocol_lwt.ml", line 41, characters 6-534:
# Error: This expression has type
#          (Lwt_io.input Lwt_io.channel * Lwt_io.output Lwt_io.channel) Lwt.t
#        but an expression was expected of type unit Lwt.t
#        Type Lwt_io.input Lwt_io.channel * Lwt_io.output Lwt_io.channel
#        is not compatible with type unit 

There is a type mismatch between the return types. I think the easiest solution is to put back the return (ic, oc) inside the catch call

[krizex]

Updated, we just need to check the exception when connecting.

[coveralls]

Coverage decreased (-0.03%) to 55.114% when pulling 243e5bc on krizex:CA-289145 into 4f2df23 on xapi-project:master.

[mseri]

I don’t understand how we decreased coverage

[krizex]

I think that's because adding 12 lines while deleting 10 lines....