Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client: Mux dispatcher thread is not stopped during disconnect #140

Open
gaborigloi opened this issue Oct 25, 2018 · 0 comments
Open

Client: Mux dispatcher thread is not stopped during disconnect #140

gaborigloi opened this issue Oct 25, 2018 · 0 comments

Comments

@gaborigloi
Copy link
Contributor

gaborigloi commented Oct 25, 2018

This is probably not a big issue in practice, because when the dispatcher background thread tries to read the next message, it will just fail and then stop. This exception in the background thread probably will not be noticed by the application using the library.
But probably it's better in general to avoid exceptions happening during normal use cases, if possible.

The only possible issue that could happen is that if reads / writes don't fail soon, then these dispatcher background threads will keep accumulating as the client connects & disconnects to/from servers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant