Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update opam files for Opam 2 #50

Merged
merged 2 commits into from Oct 30, 2018
Merged

Update opam files for Opam 2 #50

merged 2 commits into from Oct 30, 2018

Conversation

lindig
Copy link
Contributor

@lindig lindig commented Oct 30, 2018

Signed-off-by: Christian Lindig christian.lindig@citrix.com

@lindig
Update opam files for Opam 2
c5335e1 
Fix dev-repo entry to point include git protocol.

Signed-off-by: Christian Lindig <christian.lindig@citrix.com>
@lindig
Copy link
Contributor Author

lindig commented Oct 30, 2018

The problem is with the code for coverage:

[ERROR] Package bisect_ppx has no known version 1.3.0 in the repositories

In .coverage.sh:

opam pin add bisect_ppx 1.3.0 -y

@edwintorok
Copy link

edwintorok commented Oct 30, 2018 •
edited

I think we can drop the opam pin for bisect_ppx, version 1.3.0 got released a long time ago, and we have 1.3.4 in xs-opam, should be replaced with opam install.

@lindig
Coverage: install bisect_ppx, not pinning it
edbd7f0 
Signed-off-by: Christian Lindig <christian.lindig@citrix.com>
@lindig lindig merged commit 9a121be into xapi-project:master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwintorok edwintorok edwintorok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lindig @edwintorok