Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-8629: Adding travis. #155

Closed
wants to merge 3 commits into from

Conversation

siddharthv
Copy link
Contributor

Add travis for making pylint checks and verifying pull requests.

TODO:

  • Update README.md with the right badge from travis
  • Add coveralls badge

Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com>
@siddharthv
Copy link
Contributor Author

# command to run tests
script:
- "pylint --version"
- "PYTHONPATH=./snapwatchd:./drivers pylint --rcfile=tests/pylintrc ./drivers/*.py"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We no longer need snapwatchd. I also have a commit to remove it from the scripts:

https://github.com/matelakat/sm/commit/ef54cefd5375e288bb82ba43d9e4ead55dcd4f85

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, maybe pylint needs it...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its best that we include snapwatchd too

@matelakat
Copy link
Contributor

Could you add the Readme and badge changes as well, or would it require a travis account?

@@ -0,0 +1,13 @@
language: python
python:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also make sure, that we only enable master at this point?

http://docs.travis-ci.com/user/build-configuration/#White--or-blacklisting-branches

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I have a pull request to exclude xs64bit: #160

@siddharthv
Copy link
Contributor Author

I would require a travis/coveralls account to obtain the badge information.

Mate Lakat and others added 2 commits June 5, 2014 06:03
Signed-off-by: Mate Lakat <mate.lakat@citrix.com>
(cherry picked from commit 108ab81)
Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com>
@siddharthv
Copy link
Contributor Author

@matelakat
Copy link
Contributor

The reviewed pull request is here: #163

@siddharthv
Copy link
Contributor Author

Superseded by #163

@siddharthv siddharthv closed this Jun 6, 2014
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ea66f3d on siddharthv:travis-ci-pylint into * on xapi-project:master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants