-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-8629: Adding travis. #155
Conversation
Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com>
# command to run tests | ||
script: | ||
- "pylint --version" | ||
- "PYTHONPATH=./snapwatchd:./drivers pylint --rcfile=tests/pylintrc ./drivers/*.py" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We no longer need snapwatchd. I also have a commit to remove it from the scripts:
https://github.com/matelakat/sm/commit/ef54cefd5375e288bb82ba43d9e4ead55dcd4f85
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, maybe pylint needs it...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its best that we include snapwatchd too
Could you add the Readme and badge changes as well, or would it require a travis account? |
@@ -0,0 +1,13 @@ | |||
language: python | |||
python: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please also make sure, that we only enable master at this point?
http://docs.travis-ci.com/user/build-configuration/#White--or-blacklisting-branches
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I have a pull request to exclude xs64bit: #160
I would require a travis/coveralls account to obtain the badge information. |
Signed-off-by: Mate Lakat <mate.lakat@citrix.com> (cherry picked from commit 108ab81)
Signed-off-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com>
The reviewed pull request is here: #163 |
Superseded by #163 |
Changes Unknown when pulling ea66f3d on siddharthv:travis-ci-pylint into * on xapi-project:master*. |
Add travis for making pylint checks and verifying pull requests.
TODO: