CA-130987: Forward any exceptions thrown inside _snapshot #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vineeth Raveendran <vineeth.thampi@citrix.com> Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com> Imported-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com> GitHub: closes xapi-project#169 on xapi-project/sm (cherry picked from commit 6d7cf76)
|
Looks good to me - straightforward port of a simple patch - some unit tests would be fine |
andrey-podko
pushed a commit
to andrey-podko/sm
that referenced
this pull request
Aug 16, 2022
Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com> Imported-by: Siddharth Vinothkumar <siddharth.vinothkumar@citrix.com> Reviewed-by: Mate Lakat <mate.lakat@citrix.com> (cherry picked from commit 6d7cf76) GitHub: closes xapi-project#195 on xapi-project/sm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of #169 to master