Buildroot / path fixes #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables the use of xcp-sm in non-XenServer settings, such as Ubuntu or CentOS with buildroot. Note: multipath is currently not updated correctly due to the udev rules. A later patch will need to address this if multipath is to be supported outside a XenServer setting
Signed-off-by: Euan Harris <euan.harris@citrix.com>
…omments On Debian, the /etc/iscsi/initiatorname.iscsi has comments telling you what to do with the InitiatorName parameter; the previous code would try to interpret this comment as the InitiatorName setting and fail to parse it. Signed-off-by: Euan Harris <euan.harris@citrix.com>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
|
Actually, don't review this yet - I'd like to get Ubuntu working again (broken for different reasons) so I can verify this patch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various fixes needed to install xcp-sm in different contexts, particular Ubuntu, CentOS and Debian