CP-9440: Merge read caching related changes to Master #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage decreased (-0.01%) when pulling 43858f6e3d85e37755ea0a500ae8d4104621aedb on matelakat:CAR-1442-to-master into bce4501 on xapi-project:master. |
|
Coverage decreased (-0.01%) when pulling 077511976ce66c8305bafa700e7a0eb96d824b7f on matelakat:CAR-1442-to-master into bce4501 on xapi-project:master. |
In preparation for read caching, change actimeo=0 to acdirmin=0,acdirmax=0. Using "actimeo=0" prevents caching file attributes which means that each read requires a GETATTR call to the NFS server. This prevents read caching from being effective. Changing the mount options to "acdirmin=0,acdirmax=0" prevents caching directory attributes but allows caching file attributes. This allows read caching to be effective. This reverts the change made to the mount options in CA-63601. The issue in that ticket was a transient issue, fixed by a later build, before the change to the mount options was made. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> Reviewed-by: Thanos Makatos <thanos.makatos@citrix.com> GitHub: closes #135 on xapi-project/blktap (cherry picked from commit 8e505ad) Reason for cherry picking: [CP-9440] Merge read caching related changes to Master
Pass the "-D" argument to tap-ctl when opening an EXTFileVDI or an NFSFileVDI to allow read caching by removing O_DIRECT. Allow disabling read caching per-SR by setting other-config:o_direct to true. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> Reviewed-by: Thanos Makatos <thanos.makatos@citrix.com> GitHub: closes #135 on xapi-project/blktap (cherry picked from commit 4be47e0) Reason for cherry picking: [CP-9440] Merge read caching related changes to Master Conflicts: drivers/blktap2.py
With static VDIs, the SR code is run without a XAPI session. In this case, set O_DIRECT to be on for safety since there is external knob to adjust it. Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com> Reviewed-by: Thanos Makatos <thanos.makatos@citrix.com> GitHub: closes #142 on xapi-project/sm (cherry picked from commit 6c2d966) Reason for cherry picking: [CP-9440] Merge read caching related changes to Master
matelakat
changed the title
|
retest this please |
|
These changes are already in master branch (brought over from Creedence -> Trunk merge) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the cherry-pick of the read caching commits to the master branch.