CA-150404: iSCSI login fails with non-ASCII CHAP credentials #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kostaslambda
force-pushed
the
CA-150404
branch
from
d53a3a8
to
0eeadc3
Compare
|
Please test this. |
kostaslambda
force-pushed
the
CA-150404
branch
2 times, most recently
from
3236fef
to
4566eb6
Compare
|
@kostaslamda Could you please resolve the conflicts and rebase your patch ? |
|
@kostaslamda Why does a WS2012R2 target not allow non-ASCII characters for passwords ? |
The fix addresses the problem of not being able to attach an iSCSI based SR to
XenServer, if the target has specified non-ASCII characters for its CHAP
username and/or password.
Usernames: 江月, üöäÜÖÄáÀ
Passwords: 江月江月江月江月江月江月, üöäÜÖÄadmin!23
After the fix:
* Attaching an iSCSI SR using a WS2012R2 target.
Can use any non-ASCII characters for username but only ASCII for
passwords.
* Attaching an iSCSI SR using an IET target.
Can use any non-ASCII characters for username and passwords.
Signed-off-by: Kostas Ladopoulos <konstantinos.ladopoulos@citrix.com>
Signed-off-by: Kostas Ladopoulos <konstantinos.ladopoulos@citrix.com>
kostaslambda
force-pushed
the
CA-150404
branch
from
4566eb6
to
3405183
Compare
|
Please test this |
|
Please retest this |
andrey-podko
pushed a commit
to andrey-podko/sm
that referenced
this pull request
Aug 16, 2022
GitHub: closes xapi-project#230 on xapi-project/sm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix addresses the problem of not being able to attach an iSCSI based SR to
XenServer, if the target has specified non-ASCII characters for its CHAP
username and/or password.
Usernames: 江月, üöäÜÖÄáÀ
Passwords: 江月江月江月江月江月江月, üöäÜÖÄadmin!23
After the fix:
Can use any non-ASCII characters for username but only ASCII for
passwords.
Can use any non-ASCII characters for username and passwords.
Signed-off-by: Kostas Ladopoulos Konstantinos.Ladopoulos@citrix.com