CP-12403: Set backend-kind to vbd for all VDIs in LUNperVDI SRs #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tapdisk3 was introduced in Creedence, we needed to ensure that VDIs in LUNperVDI SRs continued to be plugged via blkback. This was done for the RawHBA SR (which overloads the _query() method) but not for the ISCSI SR. This patch does it on the LUNperVDI class, fixing it for the ISCSI SR. The fix consists of adding an sm-config key to all VDIs in such an SR instructing the toolstack to write in a .../vbd/... path instead of the default .../vbd3/... Signed-off-by: Felipe Franciosi <felipe@paradoxo.org>
|
Looks good and works. Please merge. |
andrey-podko
pushed a commit
to andrey-podko/sm
that referenced
this pull request
Aug 16, 2022
When tapdisk3 was introduced in Creedence, we needed to ensure that VDIs in LUNperVDI SRs continued to be plugged via blkback. This was done for the RawHBA SR (which overloads the _query() method) but not for the ISCSI SR. This patch does it on the LUNperVDI class, fixing it for the ISCSI SR. The fix consists of adding an sm-config key to all VDIs in such an SR instructing the toolstack to write in a .../vbd/... path instead of the default .../vbd3/... Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com> GitHub: closes xapi-project#252
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tapdisk3 was introduced in Creedence, we needed to ensure that VDIs in
LUNperVDI SRs continued to be plugged via blkback. This was done for the
RawHBA SR (which overloads the _query() method) but not for the ISCSI SR.
This patch does it on the LUNperVDI class, fixing it for the ISCSI SR.
The fix consists of adding an sm-config key to all VDIs in such an SR
instructing the toolstack to write in a .../vbd/... path instead of the
default .../vbd3/...
Signed-off-by: Felipe Franciosi felipe@paradoxo.org