Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-165611: DM Multipath mishandles blacklisted devices if some paths down #254

Closed
wants to merge 1 commit into from

Conversation

kostaslambda
Copy link
Contributor

This bug may occur when [1 <= paths < total_num_paths] to a device are offline
and the device is blacklisted. Up until now, we checked only the first path in
the list, which might be offline. If this was the case, we incorrectly
determined that the device was not blacklisted (the lack of the
"wwid blacklisted" string doesn't mean it's whitelisted).

To tackle the issue, we check all paths to the device until we have a definite
answer.

Signed-off-by: Kostas Ladopoulos konstantinos.ladopoulos@citrix.com

…down

This bug may occur when [1 <= paths < total_num_paths] to a device are offline
and the device is blacklisted. Up until now, we checked only the first path in
the list, which might be offline. If this was the case, we incorrectly
determined that the device was not blacklisted (the lack of the
"wwid blacklisted" string doesn't mean it's whitelisted).

To tackle the issue, we check all paths to the device until we have a definite
answer.

Signed-off-by: Kostas Ladopoulos <konstantinos.ladopoulos@citrix.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 31.66% when pulling 9083745 on kostaslamda:CA-165611 into 08d4951 on xapi-project:master.

@germanop
Copy link
Contributor

Reviewed-by: Germano Percossi germano.percossi@citrix.com

@germanop germanop closed this in 7b81acf Sep 25, 2015
andrey-podko pushed a commit to andrey-podko/sm that referenced this pull request Aug 16, 2022
…down

This bug may occur when [1 <= paths < total_num_paths] to a device are offline
and the device is blacklisted. Up until now, we checked only the first path in
the list, which might be offline. If this was the case, we incorrectly
determined that the device was not blacklisted (the lack of the
"wwid blacklisted" string doesn't mean it's whitelisted).

To tackle the issue, we check all paths to the device until we have a definite
answer.

Reviewed-by: Germano Percossi <germano.percossi@citrix.com>

GitHub: closes xapi-project#254
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants