CA-196244: Username/password made optional for SMBSR #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ] | ||
|
|
||
| if self.dconf.has_key('username') \ | ||
| and (self.dconf.has_key('password') or self.dconf.has_key('password_secret')): |
There was a problem hiding this comment.
Does the line exceed 80 chars?
There was a problem hiding this comment.
It does indeed. I have made the required changes.
|
The changes look fine to me (except for a minor comment) |
|
Looks good. |
From: Chandrika Srinivasan <chandrika.srinivasan@citrix.com> Date: Tue Feb 2 14:42:31 UTC 2016 Signed-off-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com>
andrey-podko
pushed a commit
to andrey-podko/sm
that referenced
this pull request
Aug 16, 2022
Reviewed-by: Pritha Srivastava <pritha.srivastava@citrix.com> GitHub: closes xapi-project#296
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chandrika Srinivasan chandrika.srinivasan@citrix.com