Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-15900: Handle new Tools ISO name #300

Closed
wants to merge 1 commit into from

Conversation

robhoes
Copy link
Member

@robhoes robhoes commented Feb 10, 2016

No description provided.

@robhoes
Copy link
Member Author

robhoes commented Feb 10, 2016

@chandrikas This is a followup to #297. This PR includes the patch from the other PR, because the latter was not yet merged and the new patch depends on it.

@chandrikas
Copy link
Contributor

New changes have been added to patchqueue

@germanop
Copy link
Contributor

@robhoes do they need to be 2 commits?

@robhoes
Copy link
Member Author

robhoes commented Feb 19, 2016

@germanop Nope, it just ended up this way because minds were changed along the way. Shall I squash the patches in the PR and close the other?

@germanop
Copy link
Contributor

Close all the PR that are not needed. For squashing, it is not a problem. If it needs to be one commit only, just tell me which commit message has to be kept otherwise I can push both commits.
But, yes, if you want to rearrange the commits in this PR, it is more than welcome.

I will compare it again with what we have in our patch queue to check there are no differences in code.

The name of the Tools ISO is going to change from "xs-tools.iso" to
"guest-tools.iso". This patch changes the ISOSR backend to recognise both
names, and set the VDI.name_label accordingly, to simplify the transition.

Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
@robhoes robhoes changed the title Rename tools.iso to guest-tools.iso CP-15900: Handle new Tools ISO name Feb 19, 2016
@robhoes
Copy link
Member Author

robhoes commented Feb 19, 2016

@germanop I've now combined the two patches into one, and have closed #297.

@germanop
Copy link
Contributor

Thank you. I will close this as soon as we can.

andrey-podko pushed a commit to andrey-podko/sm that referenced this pull request Aug 16, 2022
The name of the Tools ISO is going to change from "xs-tools.iso" to
"guest-tools.iso". This patch changes the ISOSR backend to recognise both
names, and set the VDI.name_label accordingly, to simplify the transition.

Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com>

GitHub: closes xapi-project#300
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants