-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CP-15900: Handle new Tools ISO name #300
Conversation
@chandrikas This is a followup to #297. This PR includes the patch from the other PR, because the latter was not yet merged and the new patch depends on it. |
New changes have been added to patchqueue |
@robhoes do they need to be 2 commits? |
@germanop Nope, it just ended up this way because minds were changed along the way. Shall I squash the patches in the PR and close the other? |
Close all the PR that are not needed. For squashing, it is not a problem. If it needs to be one commit only, just tell me which commit message has to be kept otherwise I can push both commits. I will compare it again with what we have in our patch queue to check there are no differences in code. |
The name of the Tools ISO is going to change from "xs-tools.iso" to "guest-tools.iso". This patch changes the ISOSR backend to recognise both names, and set the VDI.name_label accordingly, to simplify the transition. Signed-off-by: Rob Hoes <rob.hoes@citrix.com>
Thank you. I will close this as soon as we can. |
The name of the Tools ISO is going to change from "xs-tools.iso" to "guest-tools.iso". This patch changes the ISOSR backend to recognise both names, and set the VDI.name_label accordingly, to simplify the transition. Reviewed-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com> GitHub: closes xapi-project#300
No description provided.