CA-212295: Stale Refcount files on pool slaves after coalescing #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks fine to me |
Signed-off-by: Kostas Ladopoulos <Konstantinos.Ladopoulos@citrix.com>
kostaslambda
force-pushed
the
CA-212295
branch
5 times, most recently
from
67b3c29
to
68214c3
Compare
|
I had a look at the last changes for leaf-coalesce as well and they look good. |
|
Changes Unknown when pulling de19b0b on kostaslamda:CA-212295 into * on xapi-project:master*. |
|
@stefanopanella , would you please ack the latest change to this pull request? |
|
@kostaslamda , squash the commits and make sure the remaining one have an appropriate commit message |
Bug: - On normal coalescing, the LV that was between the 2 coalesced LVs leaves behind its Refcount on pool slaves that have the SR attached. Fix: - Reset an LV's Refcount in cleanup.LVHDSR.deleteVDI() on all pool slaves that have the SR attached. Bug: - On leaf-coalescing, the parent's Refcount is left behind on pool slaves that have the SR attached. Fix: - After the parent and leaf LV renaming, reset the LV's refcount on all pool slaves that have the SR attached. Signed-off-by: Kostas Ladopoulos <konstantinos.ladopoulos@citrix.com> Reviewed-by: Stefano Panella <stefano.panella@citrix.com>
kostaslambda
force-pushed
the
CA-212295
branch
from
de19b0b
to
991cbc6
Compare
andrey-podko
pushed a commit
to andrey-podko/sm
that referenced
this pull request
Aug 16, 2022
GitHub: closes xapi-project#314
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Force unlink a VHD's refcount in cleanup.LVHDSR.deleteVDI()
on all pool slaves.
Signed-off-by: Kostas Ladopoulos Konstantinos.Ladopoulos@citrix.com