CA-219124: Wait for NFS service to be up before attempting mount #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chandrikas
force-pushed
the
CA-219124
branch
from
1cb63b0
to
ffbcd83
Compare
|
Change looks ok. It might be an idea to add a unit test to assert that we call rpcinfo, basically the same as the modified tests but checking the other executable is called. Will make sure that we don't introduce any regressions later. |
|
Sure, will add those. |
Added wait (maximum of 3 minutes) for availability of NFS service before attempting mount of NFS share. Signed-off-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com>
chandrikas
force-pushed
the
CA-219124
branch
4 times, most recently
from
4e60c51
to
08f98d5
Compare
Signed-off-by: Chandrika Srinivasan <chandrika.srinivasan@citrix.com>
chandrikas
force-pushed
the
CA-219124
branch
from
08f98d5
to
4ad4801
Compare
andrey-podko
pushed a commit
to andrey-podko/sm
that referenced
this pull request
Aug 16, 2022
GitHub: closes xapi-project#335
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added wait (maximum of 3 minutes) for availability of NFS service
before attempting mount of NFS SR. Without this an NFS mount fails
immediately and an absence of retries leaves the NFS SR in a failed state.
Signed-off-by: Chandrika Srinivasan chandrika.srinivasan@citrix.com