Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CP-18840: Investigate leaf coalesce for file SRs #337

Closed
wants to merge 1 commit into from

Conversation

geosharath
Copy link

Enable leaf coalesce for file based SRs

Signed-off-by: Sharath Babu sharath.babu@citrix.com

Copy link
Contributor

@MarkSymsCtx MarkSymsCtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 28.681% when pulling 4434c25 on geosharath:CP-18840 into aa449fb on xapi-project:master.

Enable leaf coalesce for file based SRs

Signed-off-by: Sharath Babu <sharath.babu@citrix.com>
Reviewed-by: Mark Syms <mark.syms@citrix.com>
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 28.681% when pulling f9fe570 on geosharath:CP-18840 into aa449fb on xapi-project:master.

@germanop
Copy link
Contributor

Sorry to nitpick but commit messages have to refer to the actual code.
The fact that this code is the result of an investigation, it is of no interest for the commit message.

Please, make sure that the first line is a summary of the work done and not verbatim copy
or the originating ticket or investigation

@geosharath
Copy link
Author

sure @germanop thanks for update, i shall change it.

@germanop germanop closed this in 5d119cd Oct 19, 2016
@germanop
Copy link
Contributor

@geosharath I pushed this commit with the wrong message. I thought you had fixed it..

andrey-podko pushed a commit to andrey-podko/sm that referenced this pull request Aug 16, 2022
Enable leaf coalesce for file based SRs

Reviewed-by: Mark Syms <mark.syms@citrix.com>

GitHub: closes xapi-project#337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants