CA-327382: reap child processes #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This caused XSI-474 and other reported customer issues. Signed-off-by: Mark Syms <mark.syms@citrix.com>
TimSmithCtx
approved these changes
Sep 23, 2019
| os.killpg(pid, signal.SIGKILL) | ||
| raise AbortException("Aborting due to signal") | ||
| if timeOut and time.time() - startTime > timeOut: | ||
| os.killpg(pid, signal.SIGKILL) |
There was a problem hiding this comment.
perhaps we could tidyup by having a resultFlag.clearall() in the finally?
There was a problem hiding this comment.
perhaps we could tidyup by having a resultFlag.clearall() in the finally.
Do we still care at that point? If we entered the finally: as the result of an exception, the exception will be re-thrown when the finally completes.
| wait_pid, rc = os.waitpid(pid, os.WNOHANG) | ||
| if wait_pid == 0: | ||
| time.sleep(2) | ||
| count += 1 |
There was a problem hiding this comment.
docs say that an OSError can be raised by os.waitpid, do we want to catch it or bomb out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused XSI-474 and other reported customer issues.
Signed-off-by: Mark Syms mark.syms@citrix.com