Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/nbd #488

Merged
merged 4 commits into from
Mar 6, 2020
Merged

Feature/nbd #488

merged 4 commits into from
Mar 6, 2020

Conversation

BenSimsCitrix
Copy link
Contributor

This has past the Storage BST (125469), the storagecache suite is part of the BST, but im running independently job id 2828149

BenSimsCitrix and others added 4 commits February 14, 2020 15:35
@BenSimsCitrix @MarkSymsCtx
CP-31856 - Return nbd socket as parameter to XAPI
d5dfe94 
Signed-off-by: ben sims <ben.sims@citrix.com>
@MarkSymsCtx
CA-335178: If we don't need tap we dont have NBD
1c4985b 
Signed-off-by: Mark Syms <mark.syms@citrix.com>
@BenSimsCitrix @MarkSymsCtx
CA-335178: Fix unitialized variable
1c1d97c 
Signed-off-by: ben sims <ben.sims@citrix.com>
@BenSimsCitrix
CA-335721: Add missing case blktap2 for cached devices.
1561a43 
Signed-off-by: ben sims <ben.sims@citrix.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 39.568% when pulling 1561a43 on feature/nbd into 78946da on master.

@BenSimsCitrix
Copy link
Contributor Author

job 2828149 jusr passed

@BenSimsCitrix BenSimsCitrix marked this pull request as ready for review March 4, 2020 19:09
@BenSimsCitrix
Copy link
Contributor Author

Storage CBT (suite run 125572) succeeded I had to resubmit the suite CBT-BVT-LVM under job id 2829037 which also passed.

Storage CBT Functional (suite run 125573) succeeded apart from cbtnbdaccess which i
resubmitted under job-id 2829307 which has passed.

The initial failures were due to unrelated merge errors in xenrt.

@MarkSymsCtx
Copy link
Contributor

As we discussed yesterday, this entire area is a bit yucky and crying out for some tidying and refactoring. Let's create an improvement ticket to do that.

MarkSymsCtx
MarkSymsCtx approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@MarkSymsCtx MarkSymsCtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Baring the pre-existing yuckiness of this area of code this looks good to go further.

@BenSimsCitrix
Copy link
Contributor Author

BenSimsCitrix commented Mar 6, 2020 •
edited

Ive create CP-33286, to track the code quality issue.

@MarkSymsCtx MarkSymsCtx merged commit c86ba36 into master Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkSymsCtx MarkSymsCtx MarkSymsCtx approved these changes

@TimSmithCtx TimSmithCtx TimSmithCtx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BenSimsCitrix @coveralls @MarkSymsCtx @TimSmithCtx