Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA-331454: Handle interrupted GC #491

Merged
merged 2 commits into from
Mar 23, 2020
Merged

CA-331454: Handle interrupted GC #491

merged 2 commits into from
Mar 23, 2020

Conversation

MarkSymsCtx
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Mar 23, 2020 •
edited

Coverage Status

Coverage increased (+0.02%) to 39.578% when pulling efd47af on MarkSymsCtx:CA-331454 into 94101a9 on xapi-project:master.

BenSimsCitrix
BenSimsCitrix reviewed Mar 23, 2020
View reviewed changes
Copy link
Contributor

@BenSimsCitrix BenSimsCitrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given bash is a superset of sh, should be safe. LGTM.

BenSimsCitrix
BenSimsCitrix approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@BenSimsCitrix BenSimsCitrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given bash is a superset of sh, should be safe. LGTM.

@MarkSymsCtx
CA-331454: scan all SRs on master startup
a807e6a 
Signed-off-by: Mark Syms <mark.syms@citrix.com>
@MarkSymsCtx
CA-331454: Remove leaf coalesce journal immediately before deleting p…
efd47af 
…arent otherwise it's inconsistent

Signed-off-by: Mark Syms <mark.syms@citrix.com>
TimSmithCtx
TimSmithCtx approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@TimSmithCtx TimSmithCtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkSymsCtx MarkSymsCtx merged commit 580221d into xapi-project:master Mar 23, 2020
@MarkSymsCtx MarkSymsCtx deleted the CA-331454 branch March 23, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimSmithCtx TimSmithCtx TimSmithCtx approved these changes

@BenSimsCitrix BenSimsCitrix BenSimsCitrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarkSymsCtx @coveralls @TimSmithCtx @BenSimsCitrix