Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CA-331454: do not post attach scan ISO SRs #492

Merged
merged 1 commit into from
Mar 24, 2020
Merged

CA-331454: do not post attach scan ISO SRs #492

merged 1 commit into from
Mar 24, 2020

Conversation

MarkSymsCtx
Copy link
Contributor

No description provided.

@MarkSymsCtx
CA-331454: do not post attach scan ISO SRs
dec7015 
Signed-off-by: Mark Syms <mark.syms@citrix.com>
@coveralls
Copy link

coveralls commented Mar 23, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.0009%) to 39.579% when pulling dec7015 on MarkSymsCtx:CA-331454 into 580221d on xapi-project:master.

BenSimsCitrix
BenSimsCitrix approved these changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@BenSimsCitrix BenSimsCitrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is loads of copy and paste between ISOSR and SMBSR, might be worth checking the same problem won't pop up there.

@MarkSymsCtx
Copy link
Contributor Author

There is loads of copy and paste between ISOSR and SMBSR, might be worth checking the same problem won't pop up there.

The problem here was the tools pseudo SR which is an ISO SR but doesn't have any PBDs when being attached and so the scan fails.

@MarkSymsCtx MarkSymsCtx merged commit c9e959b into xapi-project:master Mar 24, 2020
@MarkSymsCtx MarkSymsCtx deleted the CA-331454 branch March 24, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimSmithCtx TimSmithCtx TimSmithCtx approved these changes

@BenSimsCitrix BenSimsCitrix BenSimsCitrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarkSymsCtx @coveralls @TimSmithCtx @BenSimsCitrix