Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-337352: just idempotently unlink NBD symlinks on deactivate #493

Merged
merged 1 commit into from
Apr 7, 2020

Conversation

MarkSymsCtx
Copy link
Contributor

This prevents a race if two deactivates happen concurrently.

Signed-off-by: Mark Syms mark.syms@citrix.com

TimSmithCtx
TimSmithCtx previously approved these changes Apr 6, 2020
@coveralls
Copy link

coveralls commented Apr 6, 2020

Coverage Status

Coverage decreased (-0.2%) to 39.416% when pulling ed3aa05 on MarkSymsCtx:CA-337352 into c9e959b on xapi-project:master.

Signed-off-by: Mark Syms <mark.syms@citrix.com>
@MarkSymsCtx MarkSymsCtx changed the title CA-337352: make rmdirs idempotent for ENOENT CA-337352: just idempotently unlink NBD symlinks on deactivate Apr 6, 2020
Copy link
Contributor

@BenSimsCitrix BenSimsCitrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TimSmithCtx TimSmithCtx merged commit 2d5058f into xapi-project:master Apr 7, 2020
@MarkSymsCtx MarkSymsCtx deleted the CA-337352 branch April 7, 2020 07:56
andrey-podko pushed a commit to andrey-podko/sm that referenced this pull request Aug 16, 2022
CA-337352: just idempotently unlink NBD symlinks on deactivate
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants