Some initial unit tests for mpathcount.py #500
Conversation
Signed-off-by: Tim Smith <tim.smith@citrix.com>
drivers/mpathcount.py
Outdated
| @@ -24,6 +24,19 @@ | |||
| import glob | |||
| import json | |||
|
|
|||
| supported = ['iscsi','lvmoiscsi','rawhba','lvmohba', 'ocfsohba', 'ocfsoiscsi', 'netapp','lvmofcoe', 'gfs2'] | |||
There was a problem hiding this comment.
missing space after netapp
There was a problem hiding this comment.
Was in the original. Will fix in the commit which moves it.
tests/test_mpathcount.py
Outdated
| " `- 7:0:1:4 sdam 66:96 failed faulty running" | ||
| ] | ||
| count, total = mpathcount.get_path_count('3600a098038303973743f486833396d44') | ||
| assert(total == 4) |
There was a problem hiding this comment.
self.assertEqual(4, total, msg='XXX')
There was a problem hiding this comment.
Did these things. New version pushed
tests/test_mpathcount.py
Outdated
| mpathcount.MAPPER_DIR = "test_support/fake_mapper" | ||
|
|
||
| mpathcount.update_config("fred", "3600a098038303973743f486833396d44", "[2, 4]", remove, add, True) | ||
| assert(store['MPPEnabled']) |
There was a problem hiding this comment.
self.assertIsNotNone(store['MPPEnabled'])
https://docs.python.org/3/library/unittest.html#assert-methods
There was a problem hiding this comment.
Did these things. New version pushed
Move some of the functionality of mpathcount.py into functions to make it a little easier to write unit tests for it Signed-off-by: Tim Smith <tim.smith@citrix.com>
TimSmithCtx
force-pushed
the
private/timsmi/CP-33617
branch
from
ba3f674
to
0fd0bde
Compare
tests/test_mpathcount.py
Outdated
| import SR | ||
| import util | ||
|
|
||
| #class FakeXapi(object): |
There was a problem hiding this comment.
Remove commented out code.
tests/test_mpathcount.py
Outdated
| " `- 7:0:1:4 sdam 66:96 failed faulty running" | ||
| ] | ||
| count, total = mpathcount.get_path_count('3600a098038303973743f486833396d44') | ||
| self.assertEqual(4, total, msg='total should be 4, was {}'.format(total)) |
There was a problem hiding this comment.
the format is unnecessary, the unit test assert does all that anyway. Something like "Total count incorrect" is sufficient
Signed-off-by: Tim Smith <tim.smith@citrix.com>
TimSmithCtx
force-pushed
the
private/timsmi/CP-33617
branch
from
0fd0bde
to
fb526db
Compare
No description provided.