Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for mpath_dmp #502

Merged
merged 7 commits into from
Jun 29, 2020
Merged

Add unit tests for mpath_dmp #502

merged 7 commits into from
Jun 29, 2020

Conversation

MarkSymsCtx
Copy link
Contributor

No description provided.

@MarkSymsCtx
CA-340203: remove name header from mpath map list
5ec2e23 
Signed-off-by: Mark Syms <mark.syms@citrix.com>
@MarkSymsCtx
Select specific version of mock as used by CentOS
c1b9768 
Signed-off-by: Mark Syms <mark.syms@citrix.com>
@MarkSymsCtx
CP-34042: Remove dead open-iscsi code
0b9ce52 
Signed-off-by: Mark Syms <mark.syms@citrix.com>
@MarkSymsCtx
CP-34042: Remove dead map_by_scsibus method
10c7207 
Signed-off-by: Mark Syms <mark.syms@citrix.com>
@MarkSymsCtx
CP-34042: Remove dead parameter from mpath reset
4b79a33 
Signed-off-by: Mark Syms <mark.syms@citrix.com>
@MarkSymsCtx
CP-34042: Remove dead methods from mpath modules
7892ef0 
Signed-off-by: Mark Syms <mark.syms@citrix.com>
@MarkSymsCtx
CP-34042: Add unit tests for mpath utils
362856d 
Signed-off-by: Mark Syms <mark.syms@citrix.com>
@coveralls
Copy link

Coverage Status

Coverage increased (+0.8%) to 40.245% when pulling 362856d on MarkSymsCtx:mpath_unit_tests into 45c4009 on xapi-project:master.

BenSimsCitrix
BenSimsCitrix approved these changes May 26, 2020
View reviewed changes
Copy link
Contributor

@BenSimsCitrix BenSimsCitrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarkSymsCtx MarkSymsCtx merged commit b4eb058 into xapi-project:master Jun 29, 2020
@MarkSymsCtx MarkSymsCtx deleted the mpath_unit_tests branch June 29, 2020 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimSmithCtx TimSmithCtx TimSmithCtx approved these changes

@BenSimsCitrix BenSimsCitrix BenSimsCitrix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MarkSymsCtx @coveralls @TimSmithCtx @BenSimsCitrix