Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-333441 create directory for set-iscsi-initiator #516

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

GeorgeBurac
Copy link

It appears that the directory structure for the set-iscsi-initiator script
was missing. The directory /var/lock/sm/iscsiadm was created.

Signed-off-by: Gheorghe Burac gheorghe.burac@citrix.com

@coveralls
Copy link

coveralls commented Sep 23, 2020

Coverage Status

Coverage remained the same at 44.886% when pulling 4df3107 on GeorgeBurac:CA-333441 into 21dafdc on xapi-project:master.

MarkSymsCtx
MarkSymsCtx previously approved these changes Sep 23, 2020
Copy link
Contributor

@MarkSymsCtx MarkSymsCtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@edwintorok edwintorok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could also log something to stderr at line 44, so that we get something other than exitcode 1 back from a set-iscsi-iqn failure.

edwintorok
edwintorok previously approved these changes Sep 23, 2020
It appears that the directory structure for the set-iscsi-initiator script
was missing. The directory /var/lock/sm/iscsiadm was created.

Also, when there is an active session, an error is displayed to the user.

Signed-off-by: Gheorghe Burac <gheorghe.burac@citrix.com>
Copy link
Contributor

@MarkSymsCtx MarkSymsCtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants