-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CA-333441 create directory for set-iscsi-initiator #516
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could also log something to stderr at line 44, so that we get something other than exitcode 1 back from a set-iscsi-iqn failure.
9422c9e
ba92ca8
to
9422c9e
Compare
It appears that the directory structure for the set-iscsi-initiator script was missing. The directory /var/lock/sm/iscsiadm was created. Also, when there is an active session, an error is displayed to the user. Signed-off-by: Gheorghe Burac <gheorghe.burac@citrix.com>
9422c9e
to
4df3107
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It appears that the directory structure for the set-iscsi-initiator script
was missing. The directory /var/lock/sm/iscsiadm was created.
Signed-off-by: Gheorghe Burac gheorghe.burac@citrix.com