CA-346583: make set-iscsi-initiator idempotent #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/set-iscsi-initiator
Outdated
| echo "InitiatorName=$1" > $TMPFILE | ||
| echo "InitiatorAlias=$2" >> $TMPFILE | ||
| echo "InitiatorName=$INITIATORNAME" > $TMPFILE | ||
| echo "InitiatorAlias=$INITIATORALIAS" >> $TMPFILE | ||
|
|
||
| diff $INITIATORFILE $TMPFILE > /dev/null 2>&1 |
There was a problem hiding this comment.
I think it's now doubly idempotent, if i understand lines 63 to 69 correctly.
There was a problem hiding this comment.
We can delete these lines if we are certain the new method works.
There was a problem hiding this comment.
good point. The new bit is required to avoid getting hit with the
there are active sessions so not updating
message if we're not changing anything, which happens when HA is activated
Signed-off-by: Mark Syms <mark.syms@citrix.com>
MarkSymsCtx
force-pushed
the
CA-346583
branch
from
055be64
to
893acaf
Compare
TimSmithCtx
approved these changes
Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mark Syms mark.syms@citrix.com