PPX memory interface #163
PPX memory interface #163
Conversation
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
Signed-off-by: Jon Ludlam <jonathan.ludlam@citrix.com>
|
|
||
| let service_name = "memory" | ||
| let queue_name = Xcp_service.common_prefix ^ service_name | ||
| let json_path = "/var/xapi/memory.json" | ||
| let xml_path = "/var/xapi/memory" | ||
|
|
||
| type reservation_id = string | ||
| type reservation_id = | ||
| string [@@doc [ |
There was a problem hiding this comment.
With documentation generation? 🎉
|
|
||
| let description = Interface.{ | ||
| name = "Memory"; | ||
| namespace = None; |
There was a problem hiding this comment.
What would be the effect of Some "something" here?
There was a problem hiding this comment.
It just changes the wire-name of the API call
|
The revolution is about to begin! |
There was a problem hiding this comment.
This PR could be linked as "Tutorial".
I have a question, though. Would this allow to use namespaces in the API? (I am thinking about not having to move types out of the module as for https://github.com/xapi-project/xcp-idl/blob/vgpu-migration/gpumon/gpumon_interface.ml#L28-L31)
|
For reference:
|
|
@mseri: You can certainly return different error types from different API calls - is that what you're after? |
|
Kind of. In that case I wanted to make sure that only apis in the |
|
Yes, you can declare those error types within the submodules. |
Requires PRs in squeezed and xenopsd. This is the first interface to be changed, others are to come.