updates_test: do not rely on json as a string but compare the Rpc structure #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ucture
This fixes a test that broke after the latest rpc update.
The new json serialization drops unneeded characters (e.g. pretty print newlines and spaces),
so tests that are based on specific output strings can break without any real breakage.
In this case the failure was due to:
```
got -> {"updates":[{"id":1,"v":"[\"Foo\",\"a\"]"}],"barriers":[[1,2,[{"id":1,"v":"[\"Foo\",\"a\"]"}]]]}
expected -> {"updates": [{"id": 1, "v": "[\"Foo\", \"a\"]"}], "barriers": [[1, 2, [{"id": 1, "v": "[\"Foo\", \"a\"]"}]]]}
```
The two json representations are matching but we were relying on the
wrong invariant.
This change makes the test more robust with respect to this kind of
changes, although still not perfect (the values of v are still json
strings).
Signed-off-by: Marcello Seri <marcello.seri@citrix.com>
|
Changes Unknown when pulling 583fbb0 on mseri:fix-test into ** on xapi-project:master**. |
edwintorok
approved these changes
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a test that broke after the latest rpc update.
The new json serialization drops unneeded characters (e.g. pretty print newlines and spaces),
so tests that are based on specific output strings can break without any real breakage.
In this case the failure was due to:
The two json representations are matching but we were relying on the
wrong invariant.
This change makes the test more robust with respect to this kind of
changes, although still not perfect (the values of v are still json
strings).
Signed-off-by: Marcello Seri marcello.seri@citrix.com