Change VF configuration interface to return a result type. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
Signed-off-by: Cheng Zhang <cheng.zhang@citrix.com>
- Remove unused Error results - Add a new OK result Signed-off-by: Wei Xie <wei.xie@citrix.com>
|
Today we discussed whether it is appropriate that the three functions returns the same type of sriov_action_result, because it will occur weird match with some cases that never happen. |
|
As discussed, every function should better return a different result_type. Closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Wei Xie wei.xie@citrix.com