CP-25794: Add new network backend type for network SR-IOV #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firstly, the commit message needs a signed-off-by line. |
|
Secondly, the commit message talks about adding a backend type, but the commit sneaks in a VLAN field as well... ;) |
A new network backend type for network SR-IOV VF backed vif is added. This backend type also introduces a new filed 'vlan' in 'Vif.t'. Signed-off-by: Ming Lu ming.lu@citrix.com
minglumlu
force-pushed
the
private/mingl/CP-25794
branch
from
7810e53
to
f157b15
Compare
|
@robhoes, I've refined the commit message. Thanks:) |
robhoes
approved these changes
Jan 26, 2018
|
Merge this PR as reviewed with no more comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new network backend type for network SR-IOV VF backed vif is added.
This backend type also introduces a new filed 'vlan' in 'Vif.t'.
Signed-off-by: Ming Lu ming.lu@citrix.com