Lwt_unix.{Versioned.bind_2 -> bind} #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mseri
approved these changes
Jan 29, 2018
|
This needs a better commit message: |
|
The |
added 2 commits
January 30, 2018 10:45
Lwt_unix.Versioned.bind_2 is deprecated and causes `make test` to fail. Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
Signed-off-by: Akanksha Mathur <akanksha.mathur@citrix.com>
minishrink
force-pushed
the
Lwt_bind_upgrade
branch
from
28d7de3
to
11da346
Compare
|
The failure is due to missing |
mseri
approved these changes
Jan 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/channel_helpers.ml still uses deprecated
Lwt_unix.Versioned.bind_2, causingmake testto fail.This PR updates to
Lwt_unix.bind.Signed-off-by: Akanksha Mathur akanksha.mathur@citrix.com